Fix ast-grep tests and add no-countall-number test
- Update zod-namespace-import snapshot (semicolon fix) - Add test cases for no-countall-number rule - Update rule pattern to match method calls on objects Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,16 @@
|
||||
id: no-countall-number
|
||||
snapshots:
|
||||
countAll<number>():
|
||||
fixed: countAll()
|
||||
labels:
|
||||
- source: countAll<number>()
|
||||
style: primary
|
||||
start: 0
|
||||
end: 18
|
||||
eb.fn.countAll<number>().as("count"):
|
||||
fixed: eb.fn.countAll().as("count")
|
||||
labels:
|
||||
- source: eb.fn.countAll<number>()
|
||||
style: primary
|
||||
start: 0
|
||||
end: 24
|
||||
@@ -3,7 +3,7 @@ snapshots:
|
||||
? |
|
||||
import { z } from "zod";
|
||||
: fixed: |
|
||||
import * as z from "zod"
|
||||
import * as z from "zod";
|
||||
labels:
|
||||
- source: import { z } from "zod";
|
||||
style: primary
|
||||
@@ -12,7 +12,7 @@ snapshots:
|
||||
? |
|
||||
import { z, ZodError } from "zod";
|
||||
: fixed: |
|
||||
import * as z from "zod"
|
||||
import * as z from "zod";
|
||||
labels:
|
||||
- source: import { z, ZodError } from "zod";
|
||||
style: primary
|
||||
|
||||
9
.ast-grep/rule-tests/no-countall-number-test.yml
Normal file
9
.ast-grep/rule-tests/no-countall-number-test.yml
Normal file
@@ -0,0 +1,9 @@
|
||||
id: no-countall-number
|
||||
valid:
|
||||
# Plain countAll() is fine
|
||||
- eb.fn.countAll().as("count")
|
||||
# Other type arguments are fine
|
||||
- eb.fn.countAll<string>().as("count")
|
||||
invalid:
|
||||
# countAll<number>() should be flagged
|
||||
- eb.fn.countAll<number>().as("count")
|
||||
@@ -4,5 +4,5 @@ severity: error
|
||||
message: "Don't use countAll<number>() - use countAll() instead. PostgreSQL COUNT returns bigint (string), so the type annotation is misleading."
|
||||
note: "Use Number() to convert the result if you need a number type."
|
||||
rule:
|
||||
pattern: countAll<number>()
|
||||
fix: countAll()
|
||||
pattern: $OBJ.countAll<number>()
|
||||
fix: $OBJ.countAll()
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
\restrict NNYnwssF6iMx0TXsk1nTprUEDwxna9uejAmsIiUlMLcPLlQlnnRVCusYtzweHXM
|
||||
\restrict 5BJ290gQyiWozT7xy9KK6gwHkVEhwYWnEDL73SU3eBCj2RT22vojzydS1aJAQfF
|
||||
|
||||
-- Dumped from database version 17.7
|
||||
-- Dumped by pg_dump version 17.7
|
||||
@@ -1084,7 +1084,7 @@ ALTER TABLE ONLY public.user_devices
|
||||
-- PostgreSQL database dump complete
|
||||
--
|
||||
|
||||
\unrestrict NNYnwssF6iMx0TXsk1nTprUEDwxna9uejAmsIiUlMLcPLlQlnnRVCusYtzweHXM
|
||||
\unrestrict 5BJ290gQyiWozT7xy9KK6gwHkVEhwYWnEDL73SU3eBCj2RT22vojzydS1aJAQfF
|
||||
|
||||
|
||||
--
|
||||
|
||||
Reference in New Issue
Block a user